Skip to content

Remove unused generation wrapper traits - #2083

Merged
gold-silver-copper merged 1 commit into
mainfrom
issue-2072-remove-unused-generation-wrapper-traits
Jul 9, 2026
Merged

Remove unused generation wrapper traits#2083
gold-silver-copper merged 1 commit into
mainfrom
issue-2072-remove-unused-generation-wrapper-traits

Conversation

@gold-silver-copper

Copy link
Copy Markdown
Contributor

Summary

  • Remove unused public wrapper traits AudioGeneration<M>, ImageGeneration<M>, and Transcription<M>.
  • Keep the live AudioGenerationModel, ImageGenerationModel, and TranscriptionModel APIs, request builders, clients, providers, examples, and tests intact.
  • Document the public API removal as breaking in the root and rig-core changelogs.

Closes #2072.

Validation

  • cargo fmt
  • cargo fmt --check
  • cargo check -p rig-core --all-features
  • cargo check -p rig-core --features image,audio
  • cargo test -p rig-core --features image,audio provider_response_tests
  • cargo test -p rig-core --all-features provider_response_tests
  • git diff --check
  • exact rg / git grep checks confirmed the removed wrapper traits are gone and the live model traits plus Gemini Nano Banana support remain.

Not run

  • Full workspace cargo test
  • Full cargo clippy --all-targets --all-features
  • cargo doc
  • Live provider tests requiring credentials/network

@gold-silver-copper
gold-silver-copper added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit d799996 Jul 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(core)!: delete dead capability traits AudioGeneration<M>, ImageGeneration<M>, Transcription<M>

1 participant