Remove built-in agent dynamic context#2174
Merged
Merged
Conversation
gold-silver-copper
marked this pull request as ready for review
July 17, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AgentBuilder::dynamic_context,ExtractorBuilder::dynamic_context,DynamicContextStore, and all runner/request plumbingAgentHook::on_completion_callimplementationsToolimplementationWhy
Hardcoded passive retrieval embedded application policy in agent request construction. Hooks already provide the correct per-turn policy boundary and behave consistently across blocking, streaming, and extractor execution.
Impact
This is a breaking API removal. Callers should replace
.dynamic_context(samples, index)with a local completion-call hook that queries the index and patchesRequestPatch::extra_context. Retrieval failures can stop the run before provider I/O. Model-directed retrieval remains available by exposing a vector index or custom retriever as a tool.Root cause
The original dynamic-context feature coupled vector retrieval, query selection, document formatting, and error policy to the core completion builder. Removing that special path leaves one managed execution lifecycle and makes retrieval policy explicit.
Verification
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo testcargo doc --workspace --no-depscargo check -p rig-core --target wasm32-unknown-unknown --features wasmExternal-service-backed examples were compiled but not executed.