Skip to content

eth/gasprice: fix percentile validation in eth_feeHistory - #1235

Merged
marcello33 merged 1 commit into
v1.4.0-beta-candidatefrom
mardizzone/POS-2569
May 1, 2024
Merged

eth/gasprice: fix percentile validation in eth_feeHistory#1235
marcello33 merged 1 commit into
v1.4.0-beta-candidatefrom
mardizzone/POS-2569

Conversation

@marcello33

Copy link
Copy Markdown
Collaborator

Description

This PR fixes the percentile validation in eth_feeHistory

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

@marcello33
marcello33 requested a review from a team May 1, 2024 11:48
@marcello33
marcello33 merged commit 2a5d02b into v1.4.0-beta-candidate May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants