Skip to content

Revert "Merge upstream_merge branch to develop (#1229)" - #1253

Merged
pratikspatil024 merged 2 commits into
developfrom
psp-develop
May 28, 2024
Merged

Revert "Merge upstream_merge branch to develop (#1229)"#1253
pratikspatil024 merged 2 commits into
developfrom
psp-develop

Conversation

@pratikspatil024

Copy link
Copy Markdown
Member

Description

The upstream merge PR#1229 was squashed and merged. So reverting the squashed commit. Will create a new PR which will not be squashed.

This reverts commit 7e2be02.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@pratikspatil024
pratikspatil024 merged commit 5db6fa7 into develop May 28, 2024
@pratikspatil024
pratikspatil024 deleted the psp-develop branch May 28, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants