Skip to content

eth/filters, rpc: add --rpc.rangelimit flag and fix filter config pass-through#2149

Merged
lucca30 merged 3 commits intov2.7.0-candidatefrom
lmartins/cherry-pick-2.6.5-into-2.7.0
Mar 19, 2026
Merged

eth/filters, rpc: add --rpc.rangelimit flag and fix filter config pass-through#2149
lucca30 merged 3 commits intov2.7.0-candidatefrom
lmartins/cherry-pick-2.6.5-into-2.7.0

Conversation

@lucca30
Copy link
Contributor

@lucca30 lucca30 commented Mar 19, 2026

Description

Cherry pick from 2.6.5 into 2.7.0

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

lucca30 added 3 commits March 19, 2026 07:04
…ass-through (#2147)

* Include range limit filter flag

* update docs

* apply more range checks
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

@sonarqubecloud
Copy link

@claude
Copy link

claude bot commented Mar 19, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@pratikspatil024 pratikspatil024 changed the title Cherry pick 2.6.5 into 2.7.0 eth/filters, rpc: add --rpc.rangelimit flag and fix filter config pass-through Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v2.7.0-candidate@2b949e9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
eth/filters/api.go 88.46% 2 Missing and 1 partial ⚠️
eth/filters/bor_api.go 57.14% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (86.95%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             v2.7.0-candidate    #2149   +/-   ##
===================================================
  Coverage                    ?   51.59%           
===================================================
  Files                       ?      882           
  Lines                       ?   154185           
  Branches                    ?        0           
===================================================
  Hits                        ?    79545           
  Misses                      ?    69467           
  Partials                    ?     5173           
Files with missing lines Coverage Δ
eth/backend.go 52.47% <100.00%> (ø)
eth/ethconfig/config.go 78.94% <ø> (ø)
eth/filters/filter_system.go 80.41% <ø> (ø)
internal/cli/server/config.go 65.00% <100.00%> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
eth/filters/api.go 53.87% <88.46%> (ø)
eth/filters/bor_api.go 36.06% <57.14%> (ø)
Files with missing lines Coverage Δ
eth/backend.go 52.47% <100.00%> (ø)
eth/ethconfig/config.go 78.94% <ø> (ø)
eth/filters/filter_system.go 80.41% <ø> (ø)
internal/cli/server/config.go 65.00% <100.00%> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
eth/filters/api.go 53.87% <88.46%> (ø)
eth/filters/bor_api.go 36.06% <57.14%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucca30 lucca30 merged commit 7d6a68d into v2.7.0-candidate Mar 19, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants