eth/ethconfig: remove redundant RPCLogQueryLimit field#2154
Open
lucca30 wants to merge 2 commits intov2.7.0-candidatefrom
Open
eth/ethconfig: remove redundant RPCLogQueryLimit field#2154lucca30 wants to merge 2 commits intov2.7.0-candidatefrom
lucca30 wants to merge 2 commits intov2.7.0-candidatefrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.77.0 to 1.79.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.77.0...v1.79.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
LogQueryLimit was introduced from an upstream Geth merge (dce511c); RPCLogQueryLimit was added later when wiring the internal CLI, creating a duplicate. Both were always set to the same value from --rpc.logquerylimit; filters read RPCLogQueryLimit while LogQueryLimit was dead code. Remove RPCLogQueryLimit and make LogQueryLimit the single field. No user-facing change: the --rpc.logquerylimit CLI flag and the logquerylimit TOML key are unchanged.
lucca30
force-pushed
the
lmartins/lmartins/pos-3520-remove-rpc-log-query-limit-dup
branch
from
48e8e41 to
7acdc6e
Compare
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.7.0-candidate #2154 +/- ##
===================================================
Coverage ? 51.60%
===================================================
Files ? 882
Lines ? 154208
Branches ? 0
===================================================
Hits ? 79575
Misses ? 69462
Partials ? 5171
🚀 New features to boost your workflow:
|
kamuikatsurgi
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogQueryLimitwas introduced from an upstream Geth merge (dce511c1e);RPCLogQueryLimitwas added later when wiring the internal CLI server, creating a duplicate field.--rpc.logquerylimit; the filter system readRPCLogQueryLimitwhileLogQueryLimitsat unused.RPCLogQueryLimitand makesLogQueryLimitthe single source of truth.Details
No user-facing change: the
--rpc.logquerylimitCLI flag and thelogquerylimitTOML key are unchanged. The default of 1000 is preserved viaethconfig.Defaults.LogQueryLimit.Migration note for direct Go API consumers: if you reference
ethconfig.Config.RPCLogQueryLimitdirectly, switch toethconfig.Config.LogQueryLimit.Credits to @kamuikatsurgi for catching the duplicate in the review of #2149 and #2150.
Test plan
go build ./...— compiles cleanlygo test ./eth/filters/... ./internal/cli/server/...— all passgrep -rn "RPCLogQueryLimit" . --include="*.go"— zero resultsdevnet.yaml, 2 validators) with--rpc.logquerylimit 5:Log query limit active limit=5eth_getLogswith 4 addresses (≤5): returns results normallyeth_getLogswith 6 addresses (>5): returnsexceed max addresses or topics per search position