Migrate BS-RoFormer to model spec v1 - #142
Merged
Merged
Conversation
mirek190
marked this pull request as ready for review
July 28, 2026 19:05
Owner
|
Thanks @mirek190, all three PRs have been merged! |
mpulukkinen
pushed a commit
to mpulukkinen/audio.cpp
that referenced
this pull request
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates BS-RoFormer to the current schema-v1 model-spec architecture described in #128 without changing the shared Mel-Band RoFormer interface.
model_specs/bs_roformer.jsonthe single source of truth withschema_version: 1, typed metadata/options, package/UI hints, and GGUF/safetensors resourcesmodel_specs_v1/bs_roformer.jsonmake_bs_roformer_loader()to the generic spec-backed loader path beside the shared sessionModelContractinto shared RoFormer session construction and validatesbs_roformer.*session keys against itbs_roformer.weight_typeandbs_roformer.num_overlapas the public namespaced session interfaceShared-loader handling
BS-RoFormer and Mel-Band RoFormer share assets/runtime/session source files. This migration is additive: the generated registry includes the existing Mel-Band loader factory from
loader.hand the new BS schema-backed factory fromsession.h. The old BS factory is removed from the custom loader, avoiding duplicate registration while leaving Mel-Band intact.Validation
main(c0d1c9f)AUDIOCPP_MODEL_SET=custom,AUDIOCPP_MODELS=bs_roformer, targetaudiocpp_clibs_roformer.num_overlap=1: passed; generatedvocals.wavandinstrumental.wavin 20.120 s session timemel_band_roformer.weight_typeinterface is exposedgit diff --check: passedNo model output or performance behavior is intentionally changed by this migration.