vulkan: disable integer dot product on AMD proprietary driver without… - #193
Merged
0xShug0 merged 1 commit intoAug 7, 2026
Merged
Conversation
… native dot4 The AMD proprietary Windows driver advertises integerDotProduct4x8BitPackedSignedAccelerated on GPUs without native dot4 hardware (GCN/RDNA1/RDNA2), but the emulated integer dot product path silently produces incorrect quantized matmul results (e.g. q8_0 TTS output saturated to full scale). RADV reports accelerated=false on the same hardware, and RDNA3+ has native dot4 support, so restrict the workaround to the affected combination. Equivalent to setting GGML_VK_DISABLE_INTEGER_DOT_PRODUCT=1 on these devices. Refs: 0xShug0#192
Owner
|
Thank you @IIIIIllllIIIIIlllll! Great work! I'm really glad to have your help on the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #192
On AMD GPUs without native dot4 hardware (GCN/RDNA1/RDNA2, e.g. RX 6800), the AMD proprietary Windows driver advertises integerDotProduct4x8BitPackedSignedAccelerated=true, so ggml-vulkan routes q8_0 matmuls through the integer-dot path (dotPacked4x8EXT). That path silently produces wrong results there — with the default q8_0 Irodori-TTS package the output WAV is saturated to a constant +32767 with no error or abnormal metric. RADV reports accelerated=false on the same hardware, and RDNA3+ has native dot4. Same signature reported in ollama#13108 (RX 6650 XT).
Fix
Verification
AI usage: Kimi K3 helped me find the issue and performed a fix.