Fix HIP classification in backend device test - #238
Merged
0xShug0 merged 1 commit intoAug 14, 2026
Conversation
Owner
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
backend_device_resolution_testmirrors the backend registry mapping fromsrc/framework/core/backend.cpp, but it still treated theROCmregistry as CUDA after HIP became its ownBackendType.On a HIP build, the test would discover
ROCm, request a CUDA backend, and fail instead of validating the enumerated HIP device.This change:
ROCmtoBackendType::Hipin the test contractValidation
Both focused builds and test runs passed on an Apple M3 Max with AppleClang 17.0.0:
The prior project warning about the unhandled
BackendType::Hipenum value is gone. The remaining compile warning is in the vendored ggml CPU backend.I did not have a usable HIP host for this change. A Windows CUDA attempt reached commit
4584379101c765a64fac1abc4d1e8f72fc42d2f4, but the host lacked the official CUDA Toolkit, so I am not claiming Windows GPU coverage.