docs: point flake input to upstream repository and add flake.lock - #83
Merged
Conversation
fedeizzo
changed the title
|
Can you also address the additional comments I added in #82 ? Wasn't able to complete the review before the merge |
Owner
|
@fedeizzo @francescobozzo Sorry, I thought #83 (comment) was directed at me, so I accidentally overstepped. I don’t know enough about Nix to meaningfully review these PRs, so for Nix-related changes I’ll mostly just be a button-clicking maintainer. |
Contributor
Author
Done, let me know what you think |
Owner
|
Just ping me if the PR is ready to merge. |
francescobozzo
approved these changes
Jul 21, 2026
|
LGTM |
Contributor
Author
|
@0xShug0 I think we can proceed. Once the package is more stable we can probably try to upstream in the nixpkgs repo |
Owner
|
@fedeizzo @francescobozzo Thank you! Merged. |
dleiferives
pushed a commit
to dleiferives/audio.cpp
that referenced
this pull request
Jul 25, 2026
…Shug0#83) * docs: point flake input to upstream repository * build(nix): address code review feedback on flake * build(nix): use specific torch variant depending on build flags * fix(nix): resolve undefined pkgs variable in flake evaluation * build(nix): remove internal allowUnfree to delegate permission to callers * build(nix): use allowUnfreePredicate for strict cuda license whitelisting * style(nix): rename nixpkgs instances to pkgs and pkgsCuda
Anc813
pushed a commit
to Anc813/audio.cpp
that referenced
this pull request
Jul 25, 2026
…Shug0#83) * docs: point flake input to upstream repository * build(nix): address code review feedback on flake * build(nix): use specific torch variant depending on build flags * fix(nix): resolve undefined pkgs variable in flake evaluation * build(nix): remove internal allowUnfree to delegate permission to callers * build(nix): use allowUnfreePredicate for strict cuda license whitelisting * style(nix): rename nixpkgs instances to pkgs and pkgsCuda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#82 (comment)
Last famous words 😄 I forgot to add the flake.lock file in the repo. My bad.
The lock file acts similarly to the
package-lock.jsonfor js/tsTesting