feat(generation): add validated SSE task adapter - #110
Open
xyh202131 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Review summary: two issues stand out.
Findings without inline locations
frontend/src/entities/generation/index.ts:102: The complete-animation result type only preserves URLs, but the backend action frame DTO already carriesduration_msand the frontendFramemodel can storedurationMs. Once this adapter maps the task intoGenerationResult, that timing data is gone and downstream character writes will have to invent defaults.
| ? references(input) | ||
| : input.referenceMedia.map(String).filter((url) => url.trim() !== '') | ||
| return post( | ||
| '/generation/action', |
Contributor
There was a problem hiding this comment.
This changes first_frame to /generation/action, which may be the intended runtime contract, but it now disagrees with the repo-facing API contract in frontend/API_CONTRACT.md that still documents /generation/image here. Please update that doc in the same change set, otherwise callers will implement the wrong endpoint.
This was referenced Aug 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerationApisScope
Frontend only. The backend SSE endpoint is not claimed as implemented here. No page, WorkflowRun, Controller, backend, database, log or build artifact is included.
Verification
format:checkremains blocked by 41 pre-existing files onmain; this PR keeps the generation change minimalRefs #78