feat(playtest): add asset selection entry - #213
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PlayTest had no stable navigation target without a selected character and outfit. Add protected asset selection, header and character-detail entry points, and the animated dot-matrix stage. Users can now discover PlayTest and choose a playable outfit before entering the workbench.
The new PlayTest surfaces need regression coverage across authentication, navigation, and asset states. Cover header activation, guest return paths, character-detail links, entry states, and animation timing. The tests protect the complete selection flow without relying on Canvas rendering in jsdom.
huyanxius
force-pushed
the
fix/playtest-issue
branch
from
August 11, 2026 10:13
fc2e0ec to
df26159
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Codecov reported the new canvas implementation as uncovered because the existing test stopped at a null rendering context. Run representative animation frames against a focused canvas double and verify the continuous scheduling and cleanup lifecycle. The Playtest entry and pixel stage now reach full line coverage in the targeted coverage run.
xyh202131
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
补齐 PlayTest 的稳定入口与资产选择前置页,让用户在进入试玩台前先选择具备可播放帧的角色造型,并可从角色详情直接进入试玩。
Why
原有 PlayTest 只能通过带有角色与造型 ID 的深层路由访问,顶层导航没有可靠落点;没有资产时也缺少清晰的引导界面。
Changes
PlayTest入口与激活态。Implementation
/playtest作为稳定前置路由,具体试玩仍沿用/playtest/:characterId/:outfitId。Verification
npm run format:check:通过npm run lint:通过,无警告npm run typecheck:通过npm run test:30 个测试文件、218 项测试通过npm run build:通过uv run ruff check .:通过uv run lint-imports:2 个契约通过uv run pytest -q:88 项测试通过git diff --check:通过Screenshots
Header
PlayTest Entry
Scope