feat(workspace): add creation workspace - #223
Merged
minorcell merged 16 commits intoAug 12, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
@fennoai 快起来加班了 /review |
Contributor
Review Complete已提交 1 个非阻塞 PR review，共 4 条行内问题：
|
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
huyanxius
requested review from
johnnyzhang-eng,
minorcell,
nighca,
xiaocheny214 and
xyh202131
August 11, 2026 22:14
6 tasks
Collaborator
Author
|
发现 workspace 错误地将原有的 homepage 的 workfloweditor 两个入口简化为一个入口，这个问题将在下次 commit 修复 |
Collaborator
Author
另发现 workfloweditor 不会自动创建 workflowrun，拿不到 runID 导致无法 跳转到画布界面，本次只做逻辑同步，不做修复，这个 bug 会在下一个 PR 修复 |
xyh202131
approved these changes
Aug 11, 2026
xyh202131
marked this pull request as ready for review
August 11, 2026 23:26
Collaborator
Author
|
@fennoai 再次 review |
Contributor
Re-review Complete已提交 1 个新的行内问题：
|
Member
|
Collaborator
Author
ok，代码冲突已解决 |
Contributor
我记得之前产品设计阶段提到这个功能的时候是叫它“审查台”之类的名字的？ |
Collaborator
Author
对的，但是我感觉“审查台”只能体现“审查”，体现不出“试玩”这一层意思来，没有体现我们的独特性 |
nighca
removed their request for review
August 12, 2026 06:59
The workspace needs a distinct visual cue for each creation path. Add the four restrained pixel-art assets as one reviewed set. Workspace entrances can now reveal their individual theme colors.
Creators need one fixed entry point for their existing production context. Add the four-path workspace with real project, workflow, character, and outfit data. Users can resume work without mock content or a scrolling dashboard.
The workspace and Playtest entry need the same definition of a playable outfit. Extract frame counting into the character entity and reuse it from Playtest. Both entry points now derive playback availability from real frames.
The new workspace coordinates several real navigation and context paths. Cover the fixed layout, entrance artwork, data states, retries, and selections. Regressions in the workspace routing surface are now caught locally.
Playback availability must depend on actual frames rather than action metadata. Cover outfits with and without generated animation frames. The shared entity rule is protected independently of either page.
The old placeholder home interface is no longer part of the product route. Remove its page, decorative bird, and choice card implementation. The upcoming landing page can own the root route without dead UI code.
The deleted placeholder home interface no longer has behavior to preserve. Remove its page and choice-card test files with the retired surface. The test suite now reflects the active landing and workspace boundaries.
The landing page must retain the root route while creators enter a separate workspace. Register WorkspacePage at the protected /workspace path. Authenticated navigation now has a stable workspace destination.
The workspace route must remain separate from the public landing page. Cover authenticated access to /workspace and retain the auth boundary assertions. Future route changes cannot silently put the workspace back at the root.
Frontend CI requires the workspace page to match the repository formatter. Apply the formatter to the two multiline conditional class expressions. The page now passes the targeted formatting check without behavior changes.
The workflow card lost its separate create and resume paths during the workspace redesign. Split the existing card copy into two accessible actions while preserving the artwork and restrained motion. Users can create a project through the original route or resume a real workflow from the workspace context.
The workspace coverage still targeted the removed single workflow selector. Assert the project creation route and drive resume scenarios through the renamed action. The tests now protect both entrance paths and the existing real-run selection behavior.
The desktop grid compressed the primary workspace entrances below usable widths on phones. Collapse the layout to one column and hide the contextual sidebar below the medium breakpoint. The fixed workspace canvas now keeps all four entrances available on narrow screens.
The workspace suite did not protect the responsive boundary for its primary navigation. Assert the single-column layout and hidden contextual sidebar used below the medium breakpoint. Future layout changes now preserve usable narrow-screen entrances.
The workspace described projects as update-sorted while the API currently returns identifier order. Replace the unsupported ordering claim with a neutral project-list label. The interface now matches the data contract without expanding backend scope.
The workspace suite allowed copy to promise an ordering that the project API does not provide. Assert that the update-sorting claim is absent and the neutral project-list label is rendered. Future copy changes now remain aligned with the current API contract.
huyanxius
force-pushed
the
feat/216-workspace-context-selector
branch
from
August 12, 2026 07:14
3c400f7 to
d41f366
Compare
johnnyzhang-eng
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增独立的创作工作台，用四个入口连接 Quick Start、Workflow Editor、资产库与 Playtest，并从真实项目、工作流和角色资产中恢复创作上下文。
Why
原有根页面是临时入口界面，无法承载项目、工作流和可试玩造型的真实上下文，也与正在独立开发的宣传页职责重叠。工作台需要成为登录后的稳定创作入口，同时把
/留给宣传页。Changes
/workspace，复用 Playtest 的真实帧可播放判断。Implementation
/workspace位于ProtectedRoute内；公开根路由由独立的 Landing PR 接管。frontend/src/assets/workspace/，生产代码中不包含演示或 mock 数据。Verification
npm test -- src/pages/workspace/index.test.tsx src/pages/workspace/visuals.test.tsx src/app/app.test.tsx src/app/layout/app-header.test.tsx src/entities/character/outfit-playback.test.ts src/pages/playtest/entry.test.tsx：6 个测试文件、49 项测试通过。git diff --check upstream/main...HEAD：通过。Screenshots
Desktop
Added Assets
Scope
feat/main-landing-page合入后，本分支需要更新到最新main再进入合并。main。Related Issues
Closes #216