fix: resolve stale linked issue warnings - #386
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
There was a problem hiding this comment.
The active/resolved marker transition is covered for the normal body-edit path, and the focused Node test suite passes. Two lifecycle gaps remain: manual Development-sidebar links do not invoke this resolution branch, and duplicate active warnings are only partially resolved.
| }) | ||
|
|
||
| if (comments.some((comment) => comment.body?.includes(WARNING_MARKER))) { | ||
| if (result.repository.pullRequest.closingIssuesReferences.totalCount > 0) { |
There was a problem hiding this comment.
[P1] Trigger resolution when an issue is linked from the sidebar
This branch only runs when the existing pull_request_target workflow fires, but .github/workflows/triage.yml listens to opened, edited, reopened, synchronize, and ready_for_review. Linking an issue through the Development sidebar—the workflow's warning explicitly recommends this path—does not produce one of those PR activity types, so the stale warning remains visible until some unrelated later PR event happens. Please add a trigger/path that observes manual link changes, or otherwise avoid promising automatic resolution for that supported linking method.
|
|
||
| if (comments.some((comment) => comment.body?.includes(WARNING_MARKER))) { | ||
| if (result.repository.pullRequest.closingIssuesReferences.totalCount > 0) { | ||
| const warning = comments.find(isMissingIssueWarning) |
There was a problem hiding this comment.
[P2] Resolve every active duplicate warning
Using find updates only one active warning. Duplicate warnings can already exist (for example, two overlapping workflow runs can both list comments before either creates its warning), and after this run the remaining duplicate still tells users that the linked PR has no issue. A focused reproduction with two active marker comments updates comment 1 and leaves comment 2 unresolved. Filter all active warnings and update each of them, or otherwise ensure no active marker remains once the PR is linked.
|
@fennoai fix review. |
Review fixes published
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
1 participant
Requested by @minorcell
Summary