Skip to content

fix(account): 优化账号菜单和表单提示 - #913

Merged
xiaocheny214 merged 1 commit into
1024XEngineer:mainfrom
xyh202131:fix/account-ui-polish
Aug 28, 2026
Merged

fix(account): 优化账号菜单和表单提示#913
xiaocheny214 merged 1 commit into
1024XEngineer:mainfrom
xyh202131:fix/account-ui-polish

Conversation

@xyh202131

Copy link
Copy Markdown
Contributor

Summary

  • 账号菜单支持点击外部、Escape、失焦和指针离开关闭
  • 账号侧栏在桌面端保持稳定定位
  • 优化昵称、验证码和密码输入提示,并统一默认头像

Verification

  • npm test -- --run src/app/layout/app-header.test.tsx src/pages/account/index.test.tsx(55 passed)
  • npm run typecheck
  • npm run lint
  • npm run build

Refs #783

Make the account menu dismiss predictably and clarify profile and password form inputs.

Co-authored-by: Codex <codex@openai.com>
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deployment failed for project windup with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/huyan-s-projects1?upgradeToPro=build-rate-limit

@github-actions

Copy link
Copy Markdown

⚠️ @xyh202131,此 PR 尚未关联 issue。请在 PR 描述中使用 Closes #123 等关闭关键字;更新描述后,此提醒将自动标记为已解决。

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
frontend/src/app/layout/app-header.tsx 71.42% 2 Missing and 2 partials ⚠️
frontend/src/pages/account/index.tsx 0.00% 0 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   86.50%   86.21%   -0.30%     
==========================================
  Files         304      305       +1     
  Lines       23830    23853      +23     
  Branches     3597     3605       +8     
==========================================
- Hits        20615    20565      -50     
- Misses       2249     2325      +76     
+ Partials      966      963       -3     
Flag Coverage Δ
backend 91.26% <ø> (ø)
frontend 79.99% <62.50%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
frontend/src/pages/account/index.tsx 79.38% <0.00%> (-0.31%) ⬇️
frontend/src/app/layout/app-header.tsx 91.74% <71.42%> (-3.05%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the complete fixed-range diff for the account menu and account settings changes. The account form guidance and sticky desktop navigation are consistent with their consumers, but the new pointer-dismiss interaction introduces a mouse usability regression for the menu items. Local focused tests and typecheck were not runnable because this checkout has no executable vitest/tsc dependencies.

Comment thread frontend/src/app/layout/app-header.tsx
@xiaocheny214
xiaocheny214 merged commit 69f3e8e into 1024XEngineer:main Aug 28, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants