fix(frontend): restore voice stream cancel contract types - #139
Merged
gac0812 merged 2 commits intoAug 1, 2026
Conversation
CI typecheck failed after the MVP merge dropped VoiceStreamCancelCommand/Ack while cancel handling remained in the port and fake server. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| SessionHello, | ||
| SessionReady, | ||
| VoiceParseResultMessage, | ||
| VoiceStreamCancelCommand, |
There was a problem hiding this comment.
Correctness: Importing VoiceStreamCancelCommand does not restore fake-server cancellation by itself. handleMessage still falls through to default for voice.stream.cancel, even though handleVoiceCancel already exists. Consequently, WsVoiceStreamPort.cancel() receives no acknowledgement and waits for the request timeout whenever the fake transport is used. Please restore a case 'voice.stream.cancel' branch that calls handleVoiceCancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VoiceStreamCancelCommand/VoiceStreamCancelAckafter they were dropped during theMVPmergeFakeWsServerimport for cancel handlingWhy
After #132 landed, CI typecheck failed because
VoiceStreamPortandFakeWsServerstill reference cancel types that were missing fromcontracts/voice.ts.Related
Test plan
cd frontend && npm ci && npm run typechecknpm run test -- --testPathPattern=VoiceStream