Skip to content

feat(reminder): add local mock adapters - #180

Merged
Wintercom merged 5 commits into
1024XEngineer:mainfrom
gac0812:feat/reminder-local-mocks
Aug 11, 2026
Merged

feat(reminder): add local mock adapters#180
Wintercom merged 5 commits into
1024XEngineer:mainfrom
gac0812:feat/reminder-local-mocks

Conversation

@gac0812

@gac0812 gac0812 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 落地 reminder 的 确定性本地 mock 适配器,覆盖 shared time、audio、location、notifications,以及 feature 内 local data / presentation mock。
  • Mock 只返回固定数据,用于组合与联调;不包含触发算法或平台 SDK。
  • 保留已验证的正确性修复:地点监听按每个 active location schedule 重建 watch;闹钟 rebuild 为每次请求映射唯一 receipt。
  • 同时导出 features/reminder barrel,便于后续 composition 引用。

Related issue

Scope

  • frontend/src/shared/time/**
  • frontend/src/infrastructure/audio/**
  • frontend/src/infrastructure/location/**
  • frontend/src/infrastructure/notifications/**
  • frontend/src/features/reminder/data/local/**
  • frontend/src/features/reminder/presentation/**
  • frontend/src/features/reminder/index.ts

Out of scope

Add deterministic mock adapters for reminder infrastructure and local data.

Related to 1024XEngineer#177
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
timeflow Ready Ready Preview Aug 11, 2026 8:21am

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Found two behavioral inconsistencies in the deterministic mock adapters; details are inline. Standalone typechecking is currently blocked by the PR’s documented stacked dependencies (#178 and #179), and CI reports the missing ./domain module.

View job run

Comment thread frontend/src/features/reminder/data/local/MockReminderApplication.ts Outdated
Comment thread frontend/src/infrastructure/notifications/MockDeviceCapability.ts Outdated
mac added 2 commits August 11, 2026 16:10
Bring in domain and application ports from 1024XEngineer#178/1024XEngineer#179 so CI can resolve reminder modules.
Adapt mock adapters to ReminderSnoozeRequest exclusivity and
ReminderConfirmedDisposition after merging application ports from main.
Avoid reusing fixed alarm/location listener handles so each registered
schedule can be cancelled or unwatched independently.
Return each permission's fixed MockDeviceCapability value from
requestPermission so request-then-refresh matches getStatus().

@Wintercom Wintercom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Wintercom
Wintercom merged commit cc39a79 into 1024XEngineer:main Aug 11, 2026
5 checks passed
gac0812 pushed a commit to gac0812/Tfgxs that referenced this pull request Aug 11, 2026
Bring in domain, ports, and local mocks from 1024XEngineer#178/1024XEngineer#179/1024XEngineer#180 so CI can resolve composition imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants