The 2018 Update

[joshuarli]

The changes are fairly small as this extension isn't much code, so I decided to just put everything in one PR.

Implemented:

• trim_trailing_whitespace
• end_of_line
• charset
• better error/incompatability/unsupported error messages
• changes also now applied per save ***

Revised docs and metadata:

• micro ver. 1.3.2 added support for LF and CRLF line endings, so that has been noted as the minimal compatible version
• license brought up to current year
• various english fixes in README and LICENSE and help doc
• Bumped version to 0.2.0 in repo.json

*** This can be brought up for discussion. Applying editorconfig changes per save is my personal preference (nice for things like seeing trailing whitespace go away). I believe the Atom editor also applies editorconfig per save.

[joshuarli]

Also, I just tagged a v0.2.0 release in the most recent commit!

[10sr]

Thanks 👍 I really really appreciate it!

• I think you forgot to also update this line: https://github.com/JoshuaRLi/editorconfig-micro/blob/b97902c3ed1d8b99a111271723dc48d371c13a57/editorconfig.lua#L1

Great for others!

[10sr]

As for applying editorconfig changes per save, I don't strongly oposed to this idea so it is OK!

• I think one possible idea is to add a option (something like editorconfig.reloadOnSave ?) so that users can decide this, but it may be overkill...

[joshuarli]

Whoops! Nice catch, I've updated the version there as well.

I think we can definitely do something like that if there is more feedback from users. I'm pretty surprised how few stars and attention this plugin has gotten, given the popularity of micro and the necessity of editorconfig.

[10sr]

Thanks! 🎉

BTW, if you don't mind I'd love to invite you as a collaborator of this repository.
What do you think of it? @joshuarli

[joshuarli]

Sounds good to me!

Hmm, interesting, looks like GitHub ignores tagged commits in PR merges and just assigns the tag to the merge commit. I'll probably fix the release title for v0.2.0.

[10sr]

🙌 Just invited.

I manually added v0.2.0 tag after merged. Maybe tags won't be copied to the upstream repository...

[joshuarli]

Nope, looks like you're good:

*   7658b52 - (HEAD -> master, tag: v0.2.0, origin/master, origin/HEAD) Merge pull request #3 fr
|\  
| * 4793472 - Update version in editorconfig.lua (47 minutes ago) <0x6a6f7368>
| * b97902c - v0.2.0 (13 hours ago) <Joshua Li>
| * d82663e - property is the correct term, not directive - my bad (17 hours ago) <0x6a6f7368>
| * c5807a1 - update readme (17 hours ago) <Joshua Li>
| * 417e31c - update license (17 hours ago) <Joshua Li>
| * 3406faa - update readme (17 hours ago) <Joshua Li>
| * 4e04494 - separate codingsystem into eol and charset (17 hours ago) <Joshua Li>
| * f36cd4c - implemented end of line (17 hours ago) <Joshua Li>
| * 1b47787 - better error msgs (17 hours ago) <Joshua Li>
| * f441585 - apply properties on save as well (18 hours ago) <Joshua Li>
| * 3afddc4 - trim trailing whitespace implemented (18 hours ago) <Joshua Li>
|/  
* a8c9da4 - Fix typo (1 year, 1 month ago) <10sr>
* aa19b5e - Update README.md (1 year, 1 month ago) <10sr>
* 62db3e6 - Update README.md (1 year, 1 month ago) <10sr>
* cf481b2 - Update README.md (1 year, 1 month ago) <10sr>
* 2263db3 - (tag: v0.1.1) Prepare v0.1.1 (1 year, 1 month ago) <10sr>