Skip to content

Conversation

@sudip-md
Copy link
Contributor

@sudip-md sudip-md commented Jun 17, 2024

Description of the Change

I have added test cases for Ad-Refresh-Control plugin and it is working fine in local.

Where possible, please also include:

  • Please Make sure, you have properly setup Ad-Refresh-Control plugin in you local
  • Test Is working fine in local
    image

-->

How to test the Change

Please setup plugin in loca

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@sudip-md sudip-md mentioned this pull request Jun 17, 2024
6 tasks
@jeffpaul jeffpaul requested review from a team and Sidsector9 and removed request for a team, dkotter and jeffpaul June 17, 2024 20:23
@jeffpaul jeffpaul added this to the 1.2.0 milestone Jun 17, 2024
pull_request:
branches:
- develop
jobs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sudip-md

For the pipeline, we run the tests on the release ZIP. You can refer to how we're doing it in other plugins such as Restricted Site Access and Simple Local Avatars.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 probably best if you can help update this and get merged in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 FYI that I branched #168 off this PR to hopefully help resolve your concerns here. If that looks good, go ahead and review/merge 168 and then we can proceed with the PR here.

@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jan 14, 2025
@github-project-automation github-project-automation bot moved this from To Do to QA Testing in Open Source Practice Mar 17, 2025
@Sidsector9 Sidsector9 merged commit 8c93566 into develop Mar 17, 2025
7 checks passed
@Sidsector9 Sidsector9 deleted the feature/cypress-test branch March 17, 2025 10:25
@github-project-automation github-project-automation bot moved this from QA Testing to Done in Open Source Practice Mar 17, 2025
@dkotter
Copy link
Collaborator

dkotter commented Mar 21, 2025

Just a note here that it seems E2E tests were not working coming out of this PR and #168. There's a failing test but more importantly, the tests weren't even working properly due to multiple issues (things like mochawesome not existing, trying to run a script that didn't even exist, etc). I've fixed those issues on #172 but there's still a failing test I've marked as skipped for now as it needs additional work.

Noting this mostly as a reminder that we shouldn't merge PRs in that aren't actually fully functional, as we just end up having to spend time down the line fixing those issues on unrelated PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants