Fix/slot undefined error #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
There are two bug fixes in this PR.
Another initializeSlotData() error
initializeSlotData()expects an event rather than aSlot. This PR changes out a call that was still passing the slot.Uncaught TypeError: Cannot read property 'toString' of undefined error
Within
isEligible()we were usingevent.size.toString(). It seems that thesizeproperty is only actually available on the googletag.events.slotrenderendedevent event. So when theisEligible()function was being called using googletag.events.slotvisibilitychangedevent or googletag.events.impressionviewableevent, it was erroring with a "Uncaught TypeError: Cannot read property 'toString' of undefined" error.This PR also fixes this issue by checking if
event.sizeexists before attempting to access it.Verification Process
Tested on local and preprod environments.
Checklist:
Applicable Issues
#38
Changelog Entry