Conversation
dainemawer
left a comment
There was a problem hiding this comment.
@dmtrmrv - really great job, I fully support your guidance here, I left quite a few comments - feel free to accept or ignore the suggestions. I would like to see some more concrete examples of using modern (supported) css to achieve cleaner outcomes, perhaps that can be a phase 2 thing.
joesnellpdx
left a comment
There was a problem hiding this comment.
Really awesome work! I'm sorry that some of this feedback should have been in the GDoc - but sometime swicthing context brings new perspective.
Please reach out to the team if you have any questions, thoughts, or would like some help moving anything forward!
Also, I 100% defer to you on any of my suggestions. Feel free to disregard/ignore as you see fit!
Otherwise - I approve!
Co-authored-by: Joe Snell <joesnellpdx@gmail.com>
Co-authored-by: Joe Snell <joesnellpdx@gmail.com>
Co-authored-by: Joe Snell <joesnellpdx@gmail.com>
Co-authored-by: Joe Snell <joesnellpdx@gmail.com>
… choices in documentation
…ing-Best-Practices into feature/css-best-practices
Antonio-Laguna
left a comment
There was a problem hiding this comment.
Fantastic work!
This is a clear, thoughtful, and highly practical guide.
I like the emphasis on content-first thinking, mobile-first strategy, and accessibility throughout.
The guidance on keeping specificity low, avoiding overuse of shorthands, and managing margins/gaps at the container level is really great!
The stress-testing mindset, sensible use of logical properties, and progressive enhancement with @supports and clamp() make the recommendations both modern and pragmatic.
The structure is easy to follow, examples are actionable, and the tone encourages consistency and collaboration.
Overall, this reads like a playbook teams can adopt with confidence. Great job!
I left some minor comments regarding consistency and some minor checking on grammar/clarity. There are also some suggestions on Accessibility around motion, let me know what you think!
Co-authored-by: Antonio Laguna <sombragriselros@gmail.com>
Co-authored-by: Antonio Laguna <sombragriselros@gmail.com>
Co-authored-by: Antonio Laguna <sombragriselros@gmail.com>
…ing-Best-Practices into feature/css-best-practices
|
@dmtrmrv great job working on this!! I left 2 tiny comments, and I have a more general question, I wonder if logical properties should be promoted as the default now? It makes more sense to me to always use those 🤔 |
|
Nice work @dmtrmrv . I notice that CSS logical properties is mentioned only once in an example. With excellent browser support and the significant benefits for maintainability and RTL support, maybe we should expand a little bit more on that? |
… components in CSS documentation
…ocus-visible styles for improved accessibility
…s and modifiers must not be nested inside blocks
…rasing and enhancing descriptions of utility classes and foundational styles
Description of the Change
This PR completely restructures and modernizes the CSS best practices documentation (
_includes/markdown/CSS.mdandcss.md) to provide more comprehensive, actionable, and modern guidance for writing maintainable CSS.Benefits:
Verification steps:
css.mdmatches the new section structureHow to test the Change
Build and serve the Jekyll site locally:
bundle install bundle exec jekyll serveNavigate to the CSS section (
/css/) and verify:Cross-reference with the main index page (
/) to ensure:Validate content accuracy:
Changelog Entry
Credits
Props @dmtrmrv @joesnellpdx @dainelmawer @Antonio-Laguna
Checklist: