Fix deploy script to not attempt re-publishing the same version of a plugin #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
changed the title
joemcgill
reviewed
Apr 21, 2023
Co-authored-by: Joe McGill <801097+joemcgill@users.noreply.github.com>
joemcgill
approved these changes
Apr 21, 2023
Contributor
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Thanks for accepting my suggestion, @mukeshpanchal27. This looks good to me!
felixarntz
approved these changes
Apr 21, 2023
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @mukeshpanchal27, looks great!
jeffpaul
requested review from
a team and
faisal-alvi
and removed request for
a team and
jeffpaul
tsteur
added a commit
to matomo-org/matomo-for-wordpress
that referenced
this pull request
Apr 21, 2023
11 tasks
faisal-alvi
approved these changes
Apr 24, 2023
Contributor
faisal-alvi
left a comment
faisal-alvi
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 Thanks for your work. LGTM!
johnbillion
reviewed
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I tried this solution in folk repo and here is the result for it. At the moment the WebP Uploads is release with version
1.0.0webp-uploadsand version1.0.0. It will show the message "ℹ︎ Version 1.0.0 of plugin webp-uploads was already published" and skip the script execution without throwing any errors. Check result herewebp-uploadsand version1.0.1. It will execute all the steps and commit the new version to the SVN repository(For testing i have comment the SVN commit step). Check result hereCloses #123
Credits
Props @mukeshpanchal27 @joemcgill @felixarntz
Checklist: