Add create release example #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current "Deploy on publishing a new release and attach a ZIP file to the release" example uses `actions/upload-release-asset` which is deprecated. Attaching files to a previous release doesn't seem that common in my research, the maintained GitHub release actions seem to focus on creating a release, optionally with files e.g. `softprops/action-gh-release`. This adds a "Deploy on pushing a new tag and create release with attached ZIP" example to the README which seems to be the latest approach. The implication with creating the release in an action is the changelog will be generated in the action too. I've omitted that from my example but would be happy to include if you like, perhaps there could be an `/examples` folder in this repo.
Collaborator
|
Hi there - I'm not sure I agree with your assessment that attaching files to releases after creation is uncommon, but perfectly happy to have more examples. I do think that at this point there probably should be an |
Member
|
@AlecRust any chance you want to update the PR here to add your example as a workflow file in an |
jeffpaul
added
the
needs:feedback
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The current "Deploy on publishing a new release and attach a ZIP file to the release" example uses
actions/upload-release-assetwhich is deprecated.Attaching files to an existing release doesn't seem that common in my research, the maintained GitHub release actions seem to focus on creating a release, optionally with files e.g. softprops/action-gh-release.
This adds a "Deploy on pushing a new tag and create release with attached ZIP" example to the README which is perhaps a more suitable example.
The implication with creating the release in an action is the changelog will be generated in the workflow too. I've omitted that from my example but would be happy to include if you like, perhaps there could be an
/examplesfolder in this repo.