Skip to content

fix: only flush app settings when updating app settings#892

Merged
nicholasio merged 1 commit intotrunkfrom
fix/api-cache
Apr 9, 2025
Merged

fix: only flush app settings when updating app settings#892
nicholasio merged 1 commit intotrunkfrom
fix/api-cache

Conversation

@nicholasio
Copy link
Copy Markdown
Member

Description of the Change

This is a follow up of #891

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability
Developer - Non-functional update

Credits

Props @username, @username2, ...

Checklist:

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 9, 2025

🦋 Changeset detected

Latest commit: cff7836

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@headstartwp/headstartwp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstartwp-app-router ❌ Failed (Inspect) Apr 9, 2025 9:25pm
headstarwp 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 9:25pm

@tylercherpak tylercherpak self-requested a review April 9, 2025 21:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

📦 Next.js Bundle Analysis for @10up/wp-nextjs-app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 81.74 KB (🟢 -42.23 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (145 KB)
/_error 181 B 81.92 KB 56.49% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

📦 Next.js Bundle Analysis for @10up/headstartwp

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@nicholasio nicholasio changed the base branch from develop to trunk April 9, 2025 21:23
@nicholasio nicholasio merged commit ffdd745 into trunk Apr 9, 2025
16 of 18 checks passed
@nicholasio nicholasio deleted the fix/api-cache branch April 9, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants