This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Merged
Conversation
Upgrade from Node 8 to Node 14 for sass compiling docker container.
Update / patch dependencies in a semver-compatible way.
Apply non-semver compatible dependency updates to mitigate vulnerabilities (additional work may be required to verify we haven't broken anything).
Versions of Jest prior to 25.1.0 depended on this directly. Starting with 25.1.0 it became an optional dependency. If your jest config specifies `notify: true` and `node-notifier` is _not_ present, Jest will throw an error.
Codecov Report
@@ Coverage Diff @@
## main #1308 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 51 51
Lines 2204 2204
=======================================
Hits 1952 1952
Misses 252 252 Continue to review full report at Codecov.
|
kfoley-18F
approved these changes
Jul 22, 2021
Contributor
|
Thanks @matthinz !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
sassin development to 14.17.3 (latest LTS)npm audit fixto update dependencies with vulnerabilities in a semver-compatible waynpm audit fix --forceto update dependencies with vulnerabilities in a potentially non-semver compatible waynode-notifieras a dev dependency (this was previously directly depended on by Jest, but newer Jest versions only require it if you are usingnotify: truein your jest.config.js [which we are]).This is what
npm auditlooks like now:This should close #1298
I'd like to rebase #1297 on
mainafter this lands and proceed with eliminatingnode-sassentirely.