Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58f8c19aee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ID: "121", | ||
| Disabled: false, | ||
| Title: "xpack.user.userManage", | ||
| Title: "xpack.user.accessControl", |
There was a problem hiding this comment.
Changing Title inside the existing migration 20260415-add-user-management-menu will not update already-upgraded databases, because gormigrate records migration IDs and will skip this migration once it has run. That means existing Enterprise installs keep xpack.user.userManage in HideMenu, so the access-control rename is only applied on fresh databases or ones that have not run this migration yet.
Useful? React with 👍 / 👎.
| <el-card | ||
| class="rounded-2xl shadow hover:shadow-md transition-all" | ||
| v-if="globalStore.isXpackNodeOrEE() && !globalStore.isIntl" | ||
| v-if="globalStore.isMasterPro() && !globalStore.isIntl && !globalStore.isEE()" |
There was a problem hiding this comment.
This new condition hides the SMS configuration card for Enterprise Edition (isEE()), but EE still satisfies isXpackNodeOrEE() in the alert task form and can select SMS as a send method. In that state, users can create SMS alert rules but have no UI path to set phone/daily SMS settings, which breaks SMS notification setup for EE tenants.
Useful? React with 👍 / 👎.
Co-authored-by: Copilot <copilot@github.com>
* fix: adjust access control menu (#12633) * fix: refine enterprise license required flow
2 participants
No description provided.