fix: refine enterprise license required flow#12634
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0202a095cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| is_offline: false | ||
| is_fxplay: false | ||
| is_enterprise: false | ||
| is_enterprise: true |
There was a problem hiding this comment.
Revert enterprise mode default in embedded server config
Setting base.is_enterprise to true in the embedded app.yaml makes fresh/server-default startups run in Enterprise mode by default, which forces the Enterprise license gate even when no Enterprise license is configured. The backend bootstrap path (core/init/viper/viper.go) unmarshals conf.AppYaml and uses this value for global.CONF, so this change alters runtime behavior rather than just test data.
Useful? React with 👍 / 👎.
No description provided.