feat: update vm resource messages#13216
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3015c5983d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| github.com/quic-go/quic-go v0.59.0 // indirect | ||
| github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect | ||
| github.com/sagikazarmark/locafero v0.12.0 // indirect | ||
| github.com/shirou/gopsutil/v4 v4.26.5 // indirect |
There was a problem hiding this comment.
Keep gopsutil from being tidied away
In the visible core module, rg finds no Go import of github.com/shirou/gopsutil/v4; the existing pattern for xpack-only deps is core/deps/keepdeps.go, whose comment says it keeps them from being pruned. Since go help mod tidy states that tidy “removes unused modules,” running tidy in a non-xpack checkout will drop this new requirement and its checksums, so any xpack code relying on gopsutil can later fail under a readonly module build or after a tidy. Please add the appropriate blank import to the keepdeps file, or remove this requirement if it is not actually needed.
Useful? React with 👍 / 👎.
No description provided.