Skip to content

fix: Fix an issue where an application could still be installed after its version had been deleted remotely.#13360

Merged
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@common
Jul 24, 2026
Merged

fix: Fix an issue where an application could still be installed after its version had been deleted remotely.#13360
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@common

Conversation

@zhengkunwang223

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 24, 2026 06:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a race/invalid-state path where an app could still be installed even after its selected version was removed remotely, by ensuring the UI cannot submit without a valid appDetailId and by returning a dedicated backend error when remote compose content is missing (404).

Changes:

  • Frontend: disable/guard install submission until a valid appDetailId is loaded for the selected version.
  • Frontend: reset install form state when switching versions and ignore stale getAppDetail responses.
  • Agent: propagate non-200 HTTP status codes from request helper and map 404s to ErrAppVersionUnavailable with translations.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
frontend/src/views/app-store/detail/install/index.vue Disables the confirm button and guards submit when no appDetailId is available.
frontend/src/views/app-store/detail/form/index.vue Resets version-dependent state on version change and prevents stale async responses from updating the form.
agent/utils/req_helper/request.go Returns the actual HTTP status code on non-200 responses to allow callers to distinguish 404.
agent/app/service/app.go Converts remote compose 404 into ErrAppVersionUnavailable during detail fetch and install paths.
agent/app/service/app_install.go Converts remote compose 404 into ErrAppVersionUnavailable when computing upgrade candidates.
agent/i18n/lang/zh.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/zh-Hant.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/tr.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/ru.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/pt-BR.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/ms.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/lo.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/ko.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/ja.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/fa.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/es-ES.yaml Adds ErrAppVersionUnavailable translation.
agent/i18n/lang/en.yaml Adds ErrAppVersionUnavailable translation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efa1566e43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agent/app/service/app.go
@wanghe-fit2cloud
wanghe-fit2cloud merged commit 3b91859 into dev-v2 Jul 24, 2026
4 checks passed
@wanghe-fit2cloud
wanghe-fit2cloud deleted the pr@dev-v2@common branch July 24, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants