fix: simplify cronjob record duration display - #13398
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cronjob execution record UI to display task duration (interval) in a more human-readable format, aligning with the request in Issue #13381 to convert raw seconds/milliseconds into appropriate time units.
Changes:
- Replaces inline
msvssconditional rendering with a singleformatInterval()formatter. - Adds a formatter that converts milliseconds into
hour/minute/secondcomponents (with fractional seconds).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ssongliu
force-pushed
the
fix/cronjob-record-interval-display
branch
from
July 29, 2026 02:55
e61364a to
200e69c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
frontend/src/views/cronjob/cronjob/record/index.vue:303
formatIntervalhard-codesh/min/sunit suffixes, which bypasses existing i18n unit helpers used elsewhere (e.g.frontend/src/views/toolbox/clam/operate/index.vue:98-124usescommons.units.*Unit). This will render English units even in non-English locales.
return [
hours ? `${hours}h` : '',
minutes ? `${minutes}min` : '',
seconds ? `${seconds}s` : '',
milliseconds ? `${milliseconds}ms` : '',
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #13381