Skip to content

fix default icon path interpolation#6381

Open
zhonggang666 wants to merge 1 commit into
1Panel-dev:v2from
zhonggang666:codex/split-fix-default-icon
Open

fix default icon path interpolation#6381
zhonggang666 wants to merge 1 commit into
1Panel-dev:v2from
zhonggang666:codex/split-fix-default-icon

Conversation

@zhonggang666

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Fixes defaultIcon so window.MaxKB.prefix is interpolated instead of treated as a literal string.

Closes #6369.

Summary of your change

Changes the default icon path from a normal quoted string to a template literal.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Validation: ran git diff --check.

Note: Frontend type-check was not run because this checkout does not include ui/node_modules or a frontend lockfile.

@zhonggang666 zhonggang666 changed the title [codex] fix default icon path interpolation fix default icon path interpolation Jul 9, 2026
@zhonggang666 zhonggang666 marked this pull request as ready for review July 9, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] defaultIcon uses an uninterpolated template placeholder

1 participant