Make 3rd party corpses invisible till they in fov#544
Merged
majcosta merged 3 commits intoOct 14, 2025
Conversation
majcosta
requested changes
Oct 13, 2025
Comment on lines
+2530
to
+2534
| pCorpse = GetCorpseAtGridNo(sGridNo, ubLevel); | ||
| if (pCorpse == NULL) | ||
| { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
this code already exists just 14 lines below. just put your if statement after it and delete this
| // If this is our guy......make visible... | ||
| //if ( pSoldier->bTeam == gbPlayerNum ) | ||
| if ( iCorpseID != -1 ) | ||
| if ( iCorpseID != -1 && pSoldier->bTeam == OUR_TEAM || gbPublicOpplist[OUR_TEAM][pSoldier->ubID] == SEEN_CURRENTLY ) |
Contributor
There was a problem hiding this comment.
I'm not familiar with this, does gbPublicOpplist[OUR_TEAM][pSoldier->ubID] == SEEN_CURRENTLY evaluate to false if the corpse isn't on anyone's line of sight?
Contributor
Author
There was a problem hiding this comment.
The idea here is to render immediately only those of our team and of those enemies we currently see
Contributor
There was a problem hiding this comment.
I get the idea, I just don't know how it works.
majcosta
approved these changes
Oct 13, 2025
| INT8 bToleranceThreshold = 0; | ||
| SOLDIERTYPE *pTeamSoldier; | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when non player soldier dies the corpse is rendered even if we can't see it. For example when you, soldiers, and blood cats are in the same sector and goon got killed the corpse is rendered even if your team can't see it at all. With this change such corpses won't be rendered right away, but they become visible when you come over them