Skip to content

Make 3rd party corpses invisible till they in fov #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majcosta merged 3 commits into from
Oct 14, 2025
Merged

Make 3rd party corpses invisible till they in fov #544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d26a3bd
Make 3rd party corpses invisible till they in fov
steph-pg Oct 11, 2025
e850f6c
Move visibility check after already included pCorpse check
steph-pg Oct 13, 2025
78ea232
Remove extra line
steph-pg Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Tactical/Rotting Corpses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,8 +1112,7 @@ BOOLEAN TurnSoldierIntoCorpse( SOLDIERTYPE *pSoldier, BOOLEAN fRemoveMerc, BOOLE
iCorpseID = AddRottingCorpse( &Corpse );

// If this is our guy......make visible...
//if ( pSoldier->bTeam == gbPlayerNum )
if ( iCorpseID != -1 )
if ( iCorpseID != -1 && pSoldier->bTeam == OUR_TEAM || gbPublicOpplist[OUR_TEAM][pSoldier->ubID] == SEEN_CURRENTLY )
Copy link
Copy Markdown
Contributor

@majcosta majcosta Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this, does gbPublicOpplist[OUR_TEAM][pSoldier->ubID] == SEEN_CURRENTLY evaluate to false if the corpse isn't on anyone's line of sight?

Copy link
Copy Markdown
Contributor Author

@steph-pg steph-pg Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here is to render immediately only those of our team and of those enemies we currently see

Copy link
Copy Markdown
Contributor

@majcosta majcosta Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the idea, I just don't know how it works.

{
MakeCorpseVisible( pSoldier, &( gRottingCorpse[ iCorpseID ] ) );
}
Expand Down Expand Up @@ -2540,6 +2539,9 @@ void LookForAndMayCommentOnSeeingCorpse( SOLDIERTYPE *pSoldier, INT32 sGridNo, U
return;
}

if (pCorpse->fActivated && pCorpse->def.bVisible != 1)
pCorpse->def.bVisible = 1;

if ( pCorpse->def.ubType != ROTTING_STAGE2 )
{
return;
Expand Down