Fix/drag unconscious softlock#602
Closed
tais wants to merge 2 commits into
Closed
Conversation
IsDragging() defaults to aStopIfConditionNotSatisfied=true, so these read-only cost queries could call CancelDrag() and reposition the dragged body mid-pathfind, corrupting FindBestPath's view of the world and freezing the game. Pass false so they only read state.
Same IsDragging() side-effect as the path fix: these read-only queries (movement noise, face drag icon, carried weight) must not cancel the drag or reposition the dragged body. Pass false.
Contributor
Author
|
Superseded by #603 |
majcosta
added a commit
that referenced
this pull request
Jun 2, 2026
Same logic but cleaned up version of #602 which Tais contributed with Claude Code's help Most calls to SOLDIERTYPE::IsDragging() aren't supposed to have a side effect of cancelling a drag, being simple queries. Changing the default to reflect that is right move. Assisted-by: Claude:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[16:37]Brit: Basically whenever a mercenary is in a "dying" state (black&white picture) and you try to drag them with another mercenary, they become like a "ghost" and you cannot interact or do anything with them at all. If you continue to try, eventually the game freezes.
[16:38]Brit: I have only tried in combat phase, not peaceful.
[16:39]Brit: It was a very consistent bug in my last playthrough which was V5 (buggy) but i have had in version prior too.