fix(a11y,web): adopt --tap-target tokens, extract shared .sheet-close#138
Merged
Conversation
…faces Replace hardcoded 40px with var(--tap-target), add min-block-size to padding-based buttons, and classify form inputs as primary controls (44px). 26 selectors across 10 CSS files. Closes v3.27.0 deferral + catches 6 public-surface stragglers missed in the original audit.
ama-sheet-close and compose-sheet-close were byte-for-byte identical (base rule + :hover). Move to main.css as .sheet-close, update both JS modules to use the shared class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded 40px with design tokens across authed + remaining public surfaces. Extract byte-for-byte identical sheet close buttons into a shared class.
Touch targets: 26 selectors across 10 CSS files adopt
--tap-target(44px) or--tap-target-min(24px). Closes v3.27.0 deferral + catches 6 public-surface stragglers missed in the original audit. Form inputs classified as primary interactive controls in design-language.md.Sheet-close: ama-sheet-close and compose-sheet-close were identical clones — moved to main.css as
.sheet-close, updated both JS modules. Net -16 lines.11 files, +42/-11 CSS + 5 files, +26/-42 JS/CSS.