fix(handlers): add MaxBytesReader to compose and AMA handlers#139
Merged
Conversation
HandleSubmit, HandleEdit, and AMA Answer were the only POST handlers without MaxBytesReader. Oversized bodies now return 413 instead of silently truncating or consuming unlimited memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HandleSubmit, HandleEdit, and AMA Answer were the only POST handlers without MaxBytesReader. Oversized bodies now return 413 instead of silently truncating or consuming unlimited memory.
H1: Compose HandleSubmit + HandleEdit — 1MB limit, ParseForm overflow detection, 413 on overflow.
H2: AMA Answer — 64KB limit (matches other public POST handlers), isBodyTooLarge check before JSON bind.
3 regression tests: oversized compose submission, oversized compose edit, oversized AMA answer. All assert 413.
Threat-hunt finding:
todos/security/reports/threat-hunt-2026-07-03.md.