Skip to content

Conversation

@mycprotein
Copy link

The serial gateway can only receive serial data and publish via mqtt, but can not convert mqtt into serial data. It is because the receiverReady is not handled correctly for the tx part. A quick work around is to set receiverReady to true. (it seems not used)

Description:

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@1technophile
Copy link
Owner

Do you have SENDER_SERIAL_HEARTBEAT defined ?

@mycprotein
Copy link
Author

It is not mentioned in the header file, so I initially thought it was still under construction. I recommend updating and commenting on it in the header file. Otherwise, many users may struggle to understand and utilize the tx function effectively.

@1technophile
Copy link
Owner

We could condition bool receiverReady = true; to the non definition of macro SENDER_SERIAL_HEARTBEAT

@mycprotein
Copy link
Author

Sounds great

@1technophile
Copy link
Owner

We could condition bool receiverReady = true; to the non definition of macro SENDER_SERIAL_HEARTBEAT

@mycprotein would you like to update the PR to do this ?

@mycprotein mycprotein force-pushed the serial-tx-patch branch 2 times, most recently from 3f9ad44 to 9050203 Compare January 7, 2025 12:33
The serial gateway can only receive serial data and publish via mqtt, but can not convert mqtt into serial data. It is because the receiverReady is not handled correctly for the tx part. A quick work around is to set receiverReady to true. (it seems not used)
@mycprotein
Copy link
Author

not sure if it will work

@1technophile
Copy link
Owner

not sure if it will work

Why do you think so ?

@mycprotein
Copy link
Author

I'm not a C++ programmer, so I'm not entirely sure if my modification is correct. However, it seems right to me. If it makes sense to you, then it should be fine.

@1technophile
Copy link
Owner

1technophile commented Jan 25, 2025

Please validate the PR checkboxes and we are good to merge

@github-actions github-actions bot added the stale label Apr 26, 2025
@github-actions github-actions bot closed this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants