Add explicit CI CMake presets#35
Merged
Merged
Conversation
Author
|
Currently all preset are explicit, but could be refactored to use a "base" preset and inherit from that. |
Author
|
drafting as this may conflict with another part of the master plan… |
Member
|
|
Make each CI configure environment self-contained so the jobs can later switch from ad hoc CMake flags without relying on an inherited dev-mode preset. Include the shared options assembled by the CI test script in the presets. This keeps the future cutover mechanical while leaving the CI scripts unchanged for now.
Use the explicit ci-* presets from the setup environment files and remove the duplicated per-job CMake flags now owned by those presets. Keep only caller-specific path options in the shared test script, so CI still supplies its depends toolchain and install prefix without baking those paths into reusable presets.
willcl-ark
force-pushed
the
2140-cmakepresets
branch
from
8c191ef to
0fdec54
Compare
Member
|
I'm impartial on having a base preset. This looks good to me, can we undraft and merge? |
Author
|
undrafted |
rustaceanrob
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch CI jobs to CMakePresets.
This is where flag and other configuration should naturally live, IMO.
This also makes it much easier to run the CI config with different toolchains, and other things.
edit: note this PR was 100% LLM-writted by Codex, I roughly reviewed the output, but mistakes may be present