01a052b6 - Put #bitcoin and #21gifts in kind:1 content - #72
Merged
Conversation
TaprootFreakAI
force-pushed
the
01a052b6-kind1-hashtags
branch
2 times, most recently
from
August 30, 2026 13:48
6e2090d to
291a1fd
Compare
Damus renders hashtags from note text, not from hidden t tags. Append the same discovery tags to kind:1 content and re-sign unpaid notes that still lack them. Forum message text is unchanged.
Photo notes without bytes still get #bitcoin #21gifts in content. Zap ingest fixtures must already include those tags so re-sign does not replace the event id the receipt points at.
TaprootFreakAI
force-pushed
the
01a052b6-kind1-hashtags
branch
from
August 30, 2026 13:54
291a1fd to
38e26e3
Compare
Collaborator
Author
|
EN: DE: DetailsCI on head Unpaid notes missing those hashtags are re-signed; notes with zaps keep their event id. Forum A second-vendor review is deferred to a follow-up PR, per operator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Damus shows hashtags only when they appear in the note text, not from hidden
ttags. This appends#bitcoinand#21giftsto every kind:1 content while leaving the forum row as the member wrote it. Unpaid notes that still lack those words are re-signed; notes with zaps keep their event id.DE:
Damus zeigt Hashtags nur im Notiztext, nicht aus versteckten
t-Tags. Dieser PR hängt#bitcoinund#21giftsan jeden Kind-1-Content, der Forum-Text in der Datenbank bleibt unverändert. Unbezahlte Notes ohne diese Wörter werden neu signiert; Notes mit Zaps behalten ihre Event-ID.Details
Live Damus note
ohne foto funktioniert eshadt=21gifts/t=bitcoinandr=https://21.gifts, but content was only the forum sentence. Damus (see damus-io/damus#2862) does not render hidden hashtags.buildKind1Eventnow runskind1ContentWithHashtagsafter the optional photo URL / NIP-92imeta. Frozen tags stay frozen (noe/p/q). The worker resets unpaid signed rows whose stored content lacks either hashtag (listSignedMissingHashtags+resetSignedEvent), then signs again. Zapped rows are excluded so zap receipts still resolve.This reverses the PR #51 choice not to copy the hashtags into content. The in-app thread still shows
row.textonly.