01a04a23 - Give Damus image URLs a .jpg/.png/.webp extension - #73
Merged
Conversation
Collaborator
Author
|
EN: DE: DetailsQuality nits (handbook |
TaprootFreakAI
marked this pull request as ready for review
August 30, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Damus showed forum photos as a website card (
photo/dev-api.21.gifts) because the URL ended in/photowith no image extension. Kind:1 andimetanow use/photo.jpg(or.png/.webp), and the API serves those paths. Already-published unpaid photo notes are re-signed so Damus can embed them.DE:
Damus hat Foren-Fotos als Website-Karte (
photo/dev-api.21.gifts) gezeigt, weil die URL auf/photoohne Bildendung endete. Kind:1 undimetanutzen jetzt/photo.jpg(bzw..png/.webp), und die API liefert diese Pfade. Bereits veröffentlichte, unbezahlte Foto-Notes werden neu signiert, damit Damus das Bild einbettet.Details
Damus iOS treats URLs without
.jpg/.png/.webpas web links (compass icon), even when NIP-92imetais present.forumPhotoUrlappends the MIME extension.GET /messages/:id/photo.jpg(and jpeg/png/webp) returns the same bytes as/photo, withAccess-Control-Allow-Origin: *andContent-Disposition: inline.listSignedMissingPhotonow requiresphoto.plus an extension, so existing notes with a bare/photoare re-signed after deploy.