01a052b6 - Do not reset pending notes to stamp Damus hashtags - #78
Merged
Conversation
Resetting every signed row every tick renewed the 60s sign lease, so nothing reached a relay — including new forum posts. Only published unpaid notes are re-signed, and only after unsigned rows are signed, matching the photo-URL lease rule.
Both published-only resets now run after unsigned rows are signed, so new forum posts are not queued behind a 20-row rewrite of old notes. Pending notes still EVENT without being reset. Docs match that order.
Collaborator
Author
|
EN: DE: DetailsCI on |
TaprootFreakAI
marked this pull request as ready for review
August 30, 2026 15:34
TaprootFreak
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
New forum posts were never reaching Damus because hashtag re-sign reset every unpaid note every two seconds and restarted a 60-second send lock. Photo-URL re-sign had the same lease rule but ran at a different point in the tick. Both now run after unsigned rows are signed, and only on already-published unpaid notes. Pending notes are sent as they are.
DE:
Neue Forum-Posts kamen nicht bei Damus an, weil das Hashtag-Re-Sign alle zwei Sekunden jede unbezahlte Note zurückgesetzt und die 60-Sekunden-Sendesperre neu gestartet hat. Foto-URLs hatten dieselbe Lease-Regel, liefen aber an einer anderen Stelle im Tick. Beides läuft jetzt nach dem Signieren neuer Posts und nur bei bereits veröffentlichten unbezahlten Notes. Pending Notes werden unverändert gesendet.
Details
Tick order: legacy
t=bitcoinrepair →signBatch→ photo-URL resign → hashtag resign → publish.listSignedMissingHashtagsmatcheslistSignedMissingPhoto:published,sats = 0, pending excluded. First sign still appends#bitcoin #21giftsviabuildKind1Event. Zapped rows keep their event id.