feat(workflow): materialize certified tool capabilities as nodes #49
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| import assert from "node:assert/strict" | ||
| import { existsSync, readFileSync } from "node:fs" | ||
| import { registerHooks, stripTypeScriptTypes } from "node:module" | ||
| import { test } from "node:test" | ||
| import { fileURLToPath, pathToFileURL } from "node:url" | ||
| import path from "node:path" | ||
|
|
||
| const frontendRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..") | ||
|
|
||
| registerHooks({ | ||
| resolve(specifier, context, nextResolve) { | ||
| const candidates = [] | ||
| if (specifier.startsWith("@/")) { | ||
| candidates.push(path.join(frontendRoot, specifier.slice(2))) | ||
| } else if (specifier.startsWith(".") && context.parentURL?.startsWith("file:")) { | ||
| candidates.push(path.resolve(path.dirname(fileURLToPath(context.parentURL)), specifier)) | ||
| } | ||
| for (const candidate of candidates) { | ||
| for (const resolvedPath of [candidate, `${candidate}.ts`, `${candidate}.tsx`]) { | ||
| if (existsSync(resolvedPath)) { | ||
| return { url: pathToFileURL(resolvedPath).href, shortCircuit: true } | ||
| } | ||
| } | ||
| } | ||
| return nextResolve(specifier, context) | ||
| }, | ||
| load(url, context, nextLoad) { | ||
| if (url.endsWith(".ts") || url.endsWith(".tsx")) { | ||
| const source = stripTypeScriptTypes(readFileSync(fileURLToPath(url), "utf8"), { | ||
| mode: "strip", | ||
| sourceUrl: url, | ||
| }) | ||
| return { format: "module", source, shortCircuit: true } | ||
| } | ||
| return nextLoad(url, context) | ||
| }, | ||
| }) | ||
|
|
||
| test("backend tool capability becomes an executable catalog node", async () => { | ||
| const { createWorkflowNodeFromCatalog, getWorkflowNodeCatalog } = await import( | ||
| pathToFileURL(path.join(frontendRoot, "lib/workflow/node-catalog.ts")).href | ||
| ) | ||
| const toolCapability = { | ||
| id: "tool.osint.metasearch", | ||
| versionPin: { | ||
| package: "opencli-admin", | ||
| packageVersion: "0.1.0", | ||
| capabilityVersion: "1.0.0", | ||
| provenance: "built-in", | ||
| }, | ||
| executor: { mode: "fixture", params: { limit: 20 } }, | ||
| } | ||
| const runtimeCapability = { | ||
| id: "tool.osint.metasearch", | ||
| label: "OSINT Metasearch", | ||
| surface: "catalog", | ||
| status: "runnable", | ||
| backendAvailable: true, | ||
| kind: "action", | ||
| capability: "store", | ||
| provider: "opencli-admin", | ||
| runtimeBinding: "workflow.external-tool.capability", | ||
| reason: "Search verified OSINT providers.", | ||
| missing: [], | ||
| tags: ["catalog", "tool-capability", "osint"], | ||
| source: "backend.workflow.tool_capabilities", | ||
| manifest: { | ||
| canvas: { node: true }, | ||
| nodeCatalog: { | ||
| authority: "backend", | ||
| origin: "tool-capability", | ||
| category: "processing", | ||
| }, | ||
| presentation: { | ||
| icon: "Search", | ||
| parameters: [ | ||
| { | ||
| name: "toolCapability", | ||
| label: "Tool binding", | ||
| type: "object", | ||
| required: true, | ||
| default: toolCapability, | ||
| }, | ||
| { | ||
| name: "toolParams", | ||
| label: "Runtime parameters", | ||
| type: "object", | ||
| default: { limit: 20 }, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| } | ||
| const capabilities = { | ||
| version: "test", | ||
| catalog: [runtimeCapability], | ||
| primitives: [], | ||
| channels: [], | ||
| notifiers: [], | ||
| triggers: [], | ||
| resources: [], | ||
| } | ||
|
|
||
| const item = getWorkflowNodeCatalog("intelligence", capabilities).find( | ||
| (candidate) => candidate.id === runtimeCapability.id, | ||
| ) | ||
| assert.ok(item) | ||
| assert.equal(item.kind, "action") | ||
| assert.equal(item.capability, "store") | ||
| assert.deepEqual(item.params.toolCapability, toolCapability) | ||
| assert.deepEqual(item.params.toolParams, { limit: 20 }) | ||
|
|
||
| const node = createWorkflowNodeFromCatalog(item, "osint-search", { x: 80, y: 120 }) | ||
| assert.deepEqual(node.params.toolCapability, toolCapability) | ||
| assert.deepEqual(node.params.toolParams, { limit: 20 }) | ||
| assert.equal(node.ui.catalogId, "tool.osint.metasearch") | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
No de-duplication of
catalog_idacross projected tools._tool_catalog_capabilities()emits one row per matching tool without checking whethercatalog_idcollides with another tool'snodeCatalog.id(or with a staticWORKFLOW_CATALOG_IDSentry). Since callers commonly build a{item.id: item}map, a collision means one capability silently disappears from the catalog rather than surfacing a config error.Consider tracking seen ids and raising/logging on collision (or filtering) so a copy-paste mistake in a future
catalog={...}block doesn't silently hide a tool node.Also applies to: 1457-1457, 1479-1479
🤖 Prompt for AI Agents