## What When an upload produces no cards, the upload page now shows the same info card whether the server caught it (`EmptyDeckError` → 400) or the parser produced an empty 200 response. Body copy is format-agnostic — works for Notion, markdown, csv, PDF — and links to `/documentation/help/common-problems`. Generic parser failures get a sharper fallback that names the file context and routes the user to support. Wave PR 1 of 4 from the [first-deck-success spec](#2446). Issues #721 and #731. ## Why The previous server message ("No toggles found in [filename]…") read wrong for any non-Notion upload — markdown and PDF files don't use Notion toggles, so the suggestion to "wrap your content in toggles" was incorrect for those formats. The default empty-deck body on the 200+0 path had the same Notion-centric bias. The conversion-error fallback ("Something went wrong. Try again. If the problem keeps happening, email support@2anki.net.") didn't name the file context, so users couldn't tell if it was a network issue or a parser failure. ## How - `EmptyDeckResponse` server-side now carries `code: 'empty_export'` and `docsLink: '/documentation/help/common-problems'` alongside the message. Existing `empty_export` code in `UploadErrorBody` is now actually used. - `UploadForm` routes any 400 with `code: 'empty_export'` to the existing `'emptyDeck'` zone-state (info card) instead of the generic error state. Helper `zoneStateForUploadError` keeps the three upload-handler call sites consistent. - Default `renderEmptyDeckBody` branch (non-Google-Drive) renders the spec text with an inline link to common-problems. - "Download empty deck" button is hidden when no blob is available (the 400 path has no downloadable empty deck). - `classifyUploadError` falls back to upload-context copy ("Something broke while reading this file. Try again, or send the file to support@2anki.net so we can fix the parser.") rather than the generic "Something went wrong." that's correct for thrown errors but wrong for upload responses. ## Measuring success Empty-deck-to-docs link clicks become trackable from `/documentation/help/common-problems` referrer. The parser-error fallback rate stays low (it's a true-fallback path); if it spikes, that's a regression elsewhere. ## Testing - Server: `pnpm test src/services/UploadService.test.ts` — new assertions for `code`, message, and `docsLink`. - Web: `pnpm --filter 2anki-web test:run` — three new vitest cases: - 200 + 0-cards renders the new body copy with the common-problems link - 400 + `code: 'empty_export'` lands in the emptyDeck info card (not the error state, no download button) - `classifyUploadError` unit test for the parser-error fallback - All 742 web tests + 7 UploadService server tests pass. - Web typecheck + biome lint clean. ## Risks - Behavior change: a thrown `EmptyDeckError` server-side used to render under "Something went wrong" with the WarningIcon; it now renders as the info-card empty-deck state. Visually different. - The "Download empty deck" button is now hidden when there's no blob — previously it rendered even with no link (dead click). No user impact. ## Goal alignment Activation. The first-deck-success spec frames the four upload-screen dead-ends as the cheapest activation win. Empty-deck copy that names the next step (instead of confusing non-Notion uploaders with toggle vocabulary) keeps users moving instead of bouncing. ## Drive-by fix The pre-push tsc hook caught two pre-existing errors in `src/services/NotionService/blocks/lists/BlockTable.tsx` (from PR #2445, merged earlier today) where `r.type === 'table_row'` doesn't narrow against `PartialBlockObjectResponse | BlockObjectResponse`. One commit on this branch adds the `'type' in r` guard. Existing 9 BlockTable tests still pass. ## Notes - **Changelog**: deferred per the [first-deck-success spec](#2446) — one combined changelog entry lands with the final PR of the wave (onboarding tour). The draft wording is in the spec. - **Sonar local**: skipped — anonymous run unauthorized for this project, no token configured locally. Change is copy-only plus a one-line helper; cognitive complexity unlikely.  --- <a href="https://app.blacksmith.sh/2anki/codesmith/server/pr/2453"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-in-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-in-codesmith-light.svg"><img alt="View in Codesmith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-in-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith</code> with what you need.</sup> - [ ] Let Codesmith autofix CI failures and bot reviews  --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Uh oh!

feat: create a better default error message #731

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions