fix: always paginate Notion blocks to fetch all content

[aalemayhu]

Previously getBlocks only paginated when the 'all' flag was true, but this flag was always false because ParserRules.UNLIMITED was never loaded from the database. This caused pages with 100+ blocks to be silently truncated, resulting in missing flashcards for subscribers.

Summary by CodeRabbit

• New Features

  • Enhanced Stripe subscription verification with checkout session validation
  • Added support for custom emoji and icon types in Notion blocks
  • Support for data URL images in icon rendering

• Bug Fixes

  • Improved error handling in search endpoint to catch all exception types
  • Fixed icon rendering for additional Notion icon variants

• Removed Features

  • Removed "Use All Toggle Lists" toggle option

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7e3f7fd3-85b4-45f2-85bb-48c2eeee3dba

📥 Commits

Reviewing files that changed from the base of the PR and between d4dec18 and 21dbf4f.

📒 Files selected for processing (18)

• CLAUDE.md
• src/controllers/CardOptionsController/CardOptionsController.test.ts
• src/controllers/CardOptionsController/supportedOptions.ts
• src/controllers/NotionController.ts
• src/controllers/StripeController/StripeController.test.ts
• src/controllers/StripeController/StripeController.ts
• src/lib/parser/DeckParser.test.ts
• src/lib/parser/DeckParser.ts
• src/lib/parser/ParserRules.ts
• src/lib/parser/Settings/CardOption.ts
• src/lib/parser/findNotionToggleLists.ts
• src/lib/storage/jobs/helpers/performConversion.ts
• src/services/NotionService/BlockHandler/BlockHandler.ts
• src/services/NotionService/NotionAPIWrapper.ts
• src/services/NotionService/blocks/getBlockIcon.ts
• src/services/NotionService/helpers/renderIcon.tsx
• src/usecases/jobs/CreateJobWorkSpaceUseCase.test.ts
• src/usecases/jobs/CreateJobWorkSpaceUseCase.ts

---

📝 Walkthrough

Walkthrough

The PR removes the user-facing 'all' card option and replaces its functionality with a payment-driven system where isPaying status determines toggle list processing scope. The isAll property is removed from CardOption, subscription checking logic is refactored with helper functions, and payment status flows through workspace creation to control parsing behavior.

Changes

Cohort / File(s)	Summary
Card Options Configuration CLAUDE.md, src/controllers/CardOptionsController/supportedOptions.ts, src/controllers/CardOptionsController/CardOptionsController.test.ts	Removes the 'all' card option from user-exposed supported options and updates test fixtures to reflect removal.
Core Parser Settings src/lib/parser/Settings/CardOption.ts, src/lib/parser/ParserRules.ts, src/lib/parser/findNotionToggleLists.ts	Removes isAll property from CardOption and UNLIMITED from ParserRules; updates findNotionToggleLists type signature to accept isAll as a runtime parameter instead of picking from CardOption.
Parser Logic Updates src/lib/parser/DeckParser.ts, src/lib/parser/DeckParser.test.ts	Changes DeckParser.extractToggleLists to always call findNotionToggleLists with isAll: false instead of the former settings value; updates test arguments to use new option key formats ('max-one-toggle-per-card', 'enable-input').
Subscription & Payment Integration src/controllers/StripeController/StripeController.ts, src/controllers/StripeController/StripeController.test.ts, src/usecases/jobs/CreateJobWorkSpaceUseCase.ts, src/usecases/jobs/CreateJobWorkSpaceUseCase.test.ts, src/lib/storage/jobs/helpers/performConversion.ts	Introduces isPaying parameter to workspace creation; extends Stripe integration with checkout session persistence and refactored authentication; adds comprehensive test suite for subscription status checking.
Error Handling src/controllers/NotionController.ts	Adds explicit error handling for non-APIResponseError exceptions in search error catch block.
Notion Service Updates src/services/NotionService/BlockHandler/BlockHandler.ts, src/services/NotionService/NotionAPIWrapper.ts	Replaces rules.UNLIMITED with this.useAll for block retrieval; removes timing logs from tag retrieval; refactors deck name computation.
Icon Support Expansion src/services/NotionService/blocks/getBlockIcon.ts, src/services/NotionService/helpers/renderIcon.tsx	Extends WithIcon type to support custom_emoji and icon variants; updates getBlockIcon and renderIcon to handle new icon types including data:image URLs.

Sequence Diagram

sequenceDiagram
    actor User
    participant Client
    participant StripeController
    participant AuthService
    participant StripeAPI
    participant JobConversion
    participant CreateWorkspaceUseCase
    participant DeckParser

    User->>Client: Request conversion with session_id
    Client->>JobConversion: performConversion(isPaying flag)
    JobConversion->>CreateWorkspaceUseCase: execute({api, id, owner, isPaying})
    CreateWorkspaceUseCase->>CreateWorkspaceUseCase: Set bl.useAll = isPaying
    CreateWorkspaceUseCase-->>JobConversion: Return workspace with useAll flag
    JobConversion->>DeckParser: Initialize with useAll setting
    DeckParser->>DeckParser: extractToggleLists(isAll: false)
    alt isPaying = true
        Note over DeckParser: Could process more toggles in other flow
    else isPaying = false
        DeckParser->>DeckParser: Only process first-page toggles
    end
    DeckParser-->>JobConversion: Return parsed deck
    
    User->>Client: Check subscription status
    Client->>StripeController: checkSubscriptionStatus(session_id)
    StripeController->>AuthService: getAuthenticatedUser(cookies)
    AuthService-->>StripeController: User object
    alt Patreon user
        StripeController->>StripeController: hasActiveSubscription = true
    else Has valid session_id
        StripeController->>StripeAPI: Retrieve checkout session
        StripeAPI-->>StripeController: Session with payment_status
        StripeController->>StripeController: persistStripeSession(sessionId)
    else Has active subscription
        StripeController->>StripeController: hasActiveSubscription = true
    end
    StripeController-->>Client: {hasActiveSubscription: boolean}

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: handle 3 toggle level #1886: Modifies DeckParser toggle-list handling and test fixtures with updated option key formats, sharing parser-level changes with this PR.
• feat: improve subscription management #1894: Extends StripeController's subscription-checking flow and subscription-management behavior, directly related to new payment integration changes.
• fix: ensure owner is present throughout the jobs #1816: Touches the jobs conversion flow and CreateJobWorkSpaceUseCase, sharing workspace creation code paths modified in this PR.

Poem

🐰 A rabbit rejoices, the 'all' flag removed,
Now payment unlocks the toggle-list groove!
From Stripe to workspace, the flow's been refined—
Data flows swiftly, both swift and kind.
Hops excitedly 🎉

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/notion-pagination-for-subscribers

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud