Skip to content

style: tighten PDF print options copy and color swatch#2297

Merged
aalemayhu merged 1 commit into
mainfrom
style/pdf-print-options-polish
May 15, 2026
Merged

style: tighten PDF print options copy and color swatch#2297
aalemayhu merged 1 commit into
mainfrom
style/pdf-print-options-polish

Conversation

@aalemayhu
Copy link
Copy Markdown
Contributor

@aalemayhu aalemayhu commented May 15, 2026

What

Designer-pass polish on #2296.

  • Changelog: Printable PDFs — pick background color, paper size (A4, Letter, Legal), orientation, and margins before you downloadPDF export — pick paper size (A4, Letter, Legal), orientation, margins, and page color.
  • Color swatch: full-width control → 3 rem swatch + muted tabular-nums hex readout (#FFFFFF).
  • Field label: Background colorPage background.

Why

Three things landed in #2296 that drifted from the existing in-product voice and the rest of the changelog file:

  1. The feature is "PDF export" everywhere else in product; "Printable PDFs" reintroduces a second name.
  2. before you download is filler — the reader of the What's New page already knows when settings apply.
  3. A full-width native <input type="color"> swatch alongside three selects reads visually heavier than the selects and breaks the restrained productivity-tool feel.

How

  • One-line edit in web/src/pages/WhatsNewPage/changelog.ts.
  • Color picker wrapped in a flex row: 3 rem <input type="color"> plus a <span> showing the uppercase hex in --color-text-secondary, tabular-nums for digit alignment.

Testing

  • pnpm --filter 2anki-web typecheck — green.
  • pnpm --filter 2anki-web lint — green.
  • Pure presentational change in a single component + a string; no logic to unit-test. No backend changes.

Risks

None — defaults preserved, FormData wiring unchanged, validation untouched.

Goal alignment

Mission: the print page is cleaner and the changelog reads consistently with the rest of the file. No behaviour change.

🤖 Generated with Claude Code


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

- Changelog entry leads with "PDF export" (matches in-product naming),
  drops "before you download" filler, and uses "page color" for the
  background option.
- Color picker shrinks from full-width to a 3rem swatch paired with a
  muted hex readout so it reads as a control, not a billboard.
- "Background color" label becomes "Page background" — the color is
  the page, not generic chrome.

Designer pass on #2296.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@aalemayhu aalemayhu merged commit 2a254db into main May 15, 2026
5 checks passed
@aalemayhu aalemayhu deleted the style/pdf-print-options-polish branch May 15, 2026 19:56
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant