fix: lower onboarding-tour cutoff to today's ship date#2457
Merged
Conversation
The wave's onboarding tour was gated on created_at >= 2026-06-08, the migration filename's sequential placeholder, not the calendar date. Lower the cutoff to today (2026-05-19) so accounts created from the ship date forward see the tour, matching the spec intent of "more than 24 hours before the feature ships".
❌ Deploy Preview for notion2anki failed.
|
1 similar comment
❌ Deploy Preview for notion2anki failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lowers the onboarding-tour
MIGRATION_CUTOFFconstant from'2026-06-08T00:00:00.000Z'to'2026-05-19T00:00:00.000Z'(today, the wave's ship date).Why
The just-merged tour from #2456 gates on
created_at >= MIGRATION_CUTOFF. The engineer used the migration filename20260608000000_add_onboarded_at_to_users.jsas the cutoff source, but migration filenames in this repo are sequential placeholders rather than calendar dates. Today is2026-05-19, so:created_at < 2026-06-08→ no tour (correct).created_at < 2026-06-08→ no tour (wrong — the spec says new accounts see it).Spec language: "The tour does not appear for users with
created_atmore than 24 hours before the feature ships." Feature ships today; cutoff should be today.How
One-line constant change. Vitest unit tests for
OnboardingTour.tsxuse their own localMIGRATION_DATEtest constant and pass it as themigrationDateprop, so they continue to pass without modification.Testing
pnpm --filter 2anki-web typecheckclean.pnpm --filter 2anki-web test:run— 758/758 pass./upload.Risks
None. Pre-merge no real user could see the tour; after merge new accounts see it. No data change, no migration, no shape change.
Goal alignment
Activation. The wave's tour piece is wired but invisible without this fix; this is what makes the feature actually reach the audience it was specced for.
Notes
/security-reviewneeded — pure constant change.Need help on this PR? Tag
@codesmithwith what you need.