Add import/export credentials file 2le/crudit#356 - #19
Merged
Conversation
| $output = new NullOutput(); | ||
|
|
||
| $application->run($input, $output); | ||
| } |
Contributor
There was a problem hiding this comment.
J'aurais fait un service qui est appelé par le contrôleur et la commande.
Au lieu d'appeler la commande dans le contrôleur
Contributor
There was a problem hiding this comment.
Evidement, On n'appelle jamais une commande depuis un controller
sebheitzmann
reviewed
Dec 6, 2023
| protected CredentialRepository $credentialRepository, | ||
| protected GroupCredentialRepository $groupCredentialRepository, | ||
| protected GroupRepository $groupRepository, | ||
| protected KernelInterface $kernel, |
Contributor
There was a problem hiding this comment.
j'aime pas qu'on injecte le kernelInterface pour récupérer le projectDir.
Contributor
There was a problem hiding this comment.
$this->getParameter('kernel.project_dir'); marche dans un controller
Contributor
|
magnifique. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.