fix: preserve unmanaged zero model ratios - #5
Merged
3metaJun merged 1 commit intoAug 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This change was AI-assisted and manually verified against the production failure captured by the deployment gate.
📑 变更描述 / Description
The atomic provision endpoint rejected a complete merged
ModelRatiomap whenever an unrelated legacy model had ratio0. That blocked configuration releases even though the zero-valued model was not exposed by any managed channel.Allow zero only for ratios outside enabled channels in offered groups. Managed, user-visible models still require a strictly positive ratio; negative, NaN, and infinite values remain rejected.
🚀 变更类型 / Type of change
🔆 关联任务 / Related Issue
✅ 提交前检查项 / Checklist
📳 运行证明 / Proof of Work
go test ./controller -run TestValidateMetaproxyProvisionRequest -count=1— pass.go test ./model -run TestApplyMetaproxyProvision -count=1— pass.git diff --check— pass.go test ./...reaches all packages, but the repository-wide command is not green in this checkout because the committed tree lacksweb/classic/distand an unrelated existingservicemixed-mode cache test expected 2 but observed 3.