Skip to content

Require manual approval in CircleCI for unknown submitters#38

Merged
jlledom merged 1 commit into
masterfrom
circleci-manual-approval-unknown-submitters
Jul 2, 2026
Merged

Require manual approval in CircleCI for unknown submitters#38
jlledom merged 1 commit into
masterfrom
circleci-manual-approval-unknown-submitters

Conversation

@akostadinov-bot

@akostadinov-bot akostadinov-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a manual_approval gate (type: approval) to the CircleCI workflow
  • Builds now wait for a team member to approve instead of failing when triggered by an unknown submitter
  • Follows the same pattern used in porta's CircleCI configuration

Test plan

  • CircleCI config is valid YAML with correct workflow structure
  • Verify the CircleCI workflow shows the approval step in the UI (needs CI run)

🤖 Generated with Claude Code

Adds a manual_approval gate to the CI workflow so that builds from
unknown submitters wait for team member approval instead of failing.
Follows the same pattern used in porta's CircleCI configuration.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

@jlledom jlledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine. Good job.

@jlledom
jlledom merged commit f9b13bc into master Jul 2, 2026
2 checks passed
@akostadinov-bot akostadinov-bot Bot mentioned this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant