fix(pr-title): Remove unecessary if always conditions#169
Merged
chris3ware merged 3 commits intomainfrom Mar 5, 2025
Merged
Conversation
if: always() is required to run steps that deal with failures. For example, when the PR title is invalid, the step fails but the PR comment should be created and the failure summary should be added. Delete Comment and valid title summary will always run anyway because the preceding steps have succeeded.
This workflow does not need to run when a PR is edited because this event does not generate a new commit.
chazypro
approved these changes
Mar 5, 2025
3ware-release Bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
## [4.11.1](v4.11.0...v4.11.1) (2025-03-05) ### Bug Fixes * **pr-title:** Remove unecessary `if always` conditions ([#169](#169)) ([016d847](016d847))
Contributor
|
This PR is included in version 4.11.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if: always()is not required in steps that run when the preceding step has succeeded.They only need to be used when the preceding step has failed. For example, when the PR title is invalid (and the step fails) we want the PR comment step to run anyway.